Fix false error notification

Droid-ify · Dec 10, 2023 · e2ae9c4 · e2ae9c4
1 parent 7e5ef03
commit e2ae9c4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/app/src/main/kotlin/com/looker/droidify/service/DownloadService.kt b/app/src/main/kotlin/com/looker/droidify/service/DownloadService.kt
@@ -142,7 +142,7 @@ class DownloadService : ConnectionService<DownloadService.Binder>() {
                 isUpdate = isUpdate
             )
             if (Cache.getReleaseFile(this@DownloadService, release.cacheFileName).exists()) {
-                runBlocking { publishSuccess(task) }
+                lifecycleScope.launch { publishSuccess(task) }
                 return
             }
             cancelTasks(packageName)

diff --git a/core/network/src/main/java/com/looker/network/KtorDownloader.kt b/core/network/src/main/java/com/looker/network/KtorDownloader.kt
@@ -97,11 +97,8 @@ internal class KtorDownloader : Downloader {
         } catch (e: ValidationException) {
             target.delete()
             NetworkResponse.Error.Validation(e)
-        } catch (e: URLParserException) {
-            NetworkResponse.Error.Unknown(e)
-        } catch (e: IllegalStateException) {
-            NetworkResponse.Error.Unknown(e)
-        } catch (e: IllegalArgumentException) {
+        } catch (e: Exception) {
+            e.exceptCancellation()
             NetworkResponse.Error.Unknown(e)
         }
     }