[Optimizer] allow multi exchange backtests and handle settings fallbacks #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2023
techfreaque
force-pushed
the
multi_exchange
branch
3 times, most recently
from
6fcf58d
to
ac3e774
Compare
ruidazeng
suggested changes
Nov 11, 2024
| self.required_idle_cores = int( | ||
| settings_dict.get(enums.OptimizerConfig.IDLE_CORES.value) | ||
| or constants.OPTIMIZER_DEFAULT_REQUIRED_IDLE_CORES | ||
| ) |
There was a problem hiding this comment.
I think using or when assigning default values from settings_dict can cause incorrect defaults when valid falsy values (e.g., 0, False) are provided. It might be better to change this to:
self.required_idle_cores = int(
settings_dict.get(
enums.OptimizerConfig.IDLE_CORES.value,
constants.OPTIMIZER_DEFAULT_REQUIRED_IDLE_CORES
)
)There was a problem hiding this comment.
Hi @ruidazeng
I see, I have removed those changes.
There was a problem hiding this comment.
@Herklos is this something merge-able? trying to backlog all the pull requests for OctoBot :))
There was a problem hiding this comment.
@ruidazeng Thank you but we can see the open pull requests on the OctoBot repos, can you please not do this?
techfreaque
force-pushed
the
multi_exchange
branch
from
ac3e774
to
7c7a497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the api receives a list of "exchange_ids" and/or a list of "data_files" it will optimize on multi exchanges.
Should behave the same way as before if "data_files" is a string and not a list and if no "exchange_ids" list is provided
requires:
Drakkar-Software/OctoBot-Trading#847
Drakkar-Software/OctoBot-Backtesting#172
Drakkar-Software/OctoBot-Tentacles#865