Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to enable the production branch_type never seems to get "fixed" #208

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Attempting to enable the production branch_type never seems to get "fixed" #208

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b86e741
Attempting to enable the production branch_type never seems to get "f…
May 18, 2024
30f949f
Safer version of the fix: Only copy "Enabled" for "production"
May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bitbucket/resource_branching_model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ func flattenBranchModel(rp *BranchModel, typ string) []interface{} {
"is_valid": rp.IsValid,
"use_mainbranch": rp.UseMainbranch,
"name": rp.Name,
"enabled": rp.Enabled,
Copy link
Author

@barrywhart barrywhart May 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For production, the BitBucket API returns an enabled field. We simply need to copy it from the BranchModel to the output. In the develop case, the enabled field is not present in the response and defaults to false. NOTE: In the develop case, the enabled field is also not part of the Terraform resource schema.

In light of the above, I'm not 100% sure about this fix. It seems a little hacky. Another potential option is to handle the enabled field of production separately so it doesn't affect development. Thoughts?

}

return []interface{}{m}
Expand Down
Loading