Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Maintenance #288

Merged
merged 59 commits into from
Jan 28, 2025
Merged

Package Maintenance #288

merged 59 commits into from
Jan 28, 2025

Conversation

SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Jan 13, 2025 •
edited
Loading

Changes

  • Update tests to remove unnecessary warnings
  • Include Black and Ruff for formatting and linting
  • Add differently initialized learners to examples to clarify examples (Closes Possibly error in code example doubleml-docs#209)
  • Update docstrings for sensitivity_benchmark and GlobalRegressor, GlobalClassifier

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen
change np.in1d to np.isin
60c34cc
@SvenKlaassen
nonlinear mixin change value of coef to scalar
3918bed
@SvenKlaassen
fix irm tests
ce8c254 
update coefs and ses to scalars
@SvenKlaassen
fix plm tests
1a17056 
update coef and ses to scalars
@SvenKlaassen
Merge branch 'main' into s-maintenance
3da2a42
@SvenKlaassen
ignore not relevant did test warnings
a745a65
@SvenKlaassen
ignore not relevant warnings in plm tests
81b4d57
@SvenKlaassen
update irm test warnings
b98647f
@SvenKlaassen
Update pytest.ini
630c7a2
@SvenKlaassen
Update pytest.ini
cb88bdd
@SvenKlaassen
update irm tests
3803d9f
@SvenKlaassen
Update test_iivm_tune.py
ca2a60a
@SvenKlaassen
filter warnings for rdd
2aaf28b
@SvenKlaassen
add black formatter configuration
2caeabc
@SvenKlaassen
add ruff configuration
cebd465
@SvenKlaassen
update ruff configuration
f369cb2
@SvenKlaassen
run ruff for did
5751524
@SvenKlaassen
reformat did dir
030eeae
@SvenKlaassen
run ruff for irm
f06879d
@SvenKlaassen
reformat irm dir
0251a6f
@SvenKlaassen
run ruff on plm
36ae8b2
@SvenKlaassen
reformat plm
1c31e8b
@SvenKlaassen
run ruff on rdd
28c64e1
@SvenKlaassen
format rdd
11664a2
@SvenKlaassen
run ruff on tests
b55a04f
@SvenKlaassen
format tests
74b6b3f
@SvenKlaassen
run ruff on utils
fd13e1d
@SvenKlaassen
format utils
b49a526
@SvenKlaassen
ruff doubleml
f984773
@SvenKlaassen
format doubleml
68683ac
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 13, 2025
View reviewed changes
doubleml/datasets.py Fixed Show fixed Hide fixed
doubleml/irm/tests/_utils_irm_manual.py Fixed Show fixed Hide fixed
doubleml/tests/test_datasets.py Fixed Show fixed Hide fixed
doubleml/tests/test_dml_data.py Fixed Show fixed Hide fixed
@SvenKlaassen SvenKlaassen linked an issue Jan 20, 2025 that may be closed by this pull request
Possibly error in code example DoubleML/doubleml-docs#209
Closed
@SvenKlaassen
Copy link
Member Author

@PhilippBach could you review the main changes?

The only test failing is based on complexity which was not changed and is not part of this PR (only reformatted).

PhilippBach
PhilippBach approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@PhilippBach PhilippBach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SvenKlaassen . I think the added features for maintenance look pretty nice and helpful! The PR looks good to me

@SvenKlaassen SvenKlaassen merged commit e033c3e into main Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippBach PhilippBach PhilippBach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly error in code example
2 participants
@SvenKlaassen @PhilippBach