Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed memory leak in C++ string formatting #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed memory leak in C++ string formatting #32

wants to merge 3 commits into from

Conversation

JaiganeshKumaran
Copy link

Fixes #28.

@sylveon
Copy link

sylveon commented Jan 31, 2023

These could still leak in case the creation of the string throws. Recommend using std::unique_ptr<wchar_t[]>. Alternatively for C++/WinRT, you could use winrt::format to be more efficient (since it directly gives a hstring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ string formatting is leaking memory
2 participants
@JaiganeshKumaran @sylveon