fix: Drag with mouse switch

[bazzadazza72]

Pull Request Description

Previously, the "Drag with mouse" switch in the settings would turn on the "AMOLED black" switch and would not respond to input unless the latter switch was turned off.

Now, it works as it should and responds correctly to users enabling the setting.

Issue Being Fixed

Resolves #194

Screenshots / Recordings

No screenshots/recordings required

Checklist

• If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
• Check that any changes are related to the issue at hand.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug where the "Drag with mouse" switch would activate the "AMOLED black" switch and become unresponsive unless the "AMOLED black" switch was deactivated. The fix updates the onChanged callback of the "Drag with mouse" switch to correctly toggle the mouseDragSupport setting, resolving the conflict with the "AMOLED black" setting.

Sequence diagram for fixed mouse drag switch interaction

sequenceDiagram
    actor User
    participant Switch as Mouse Drag Switch
    participant Settings as Client Settings Provider

    Note over User, Settings: Before Fix
    User->>Switch: Toggle switch
    Switch->>Settings: setAmoledBlack(value)
    Settings-->>Switch: Update AMOLED setting (incorrect)

    Note over User, Settings: After Fix
    User->>Switch: Toggle switch
    Switch->>Settings: update(mouseDragSupport: !current)
    Settings-->>Switch: Update mouse drag setting (correct)

Loading

State diagram for mouse drag switch behavior

stateDiagram-v2
    [*] --> MouseDragOff: Initial State
    MouseDragOff --> MouseDragOn: Toggle Switch
    MouseDragOn --> MouseDragOff: Toggle Switch

    note right of MouseDragOff
        Fixed: Now correctly toggles
        mouseDragSupport instead of
        AMOLED setting
    end note

Loading

File-Level Changes

Change	Details	Files
Update "Drag with mouse" switch behavior	Modified the onChanged callback to update the mouseDragSupport setting instead of the AMOLED black setting.	lib/screens/settings/client_settings_page.dart

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#194	Ensure 'Drag with mouse' switch works independently and does not automatically turn on 'AMOLED black' switch	✅
#194	Fix the switch's behavior to respond correctly when enabled	✅

Possibly linked issues

• 🐛 Drag with mouse switch turns on AMOLED black switch #194: The PR fixes the issue where the "Drag with mouse" switch incorrectly turned on the "AMOLED black" switch. The PR updates the onChanged callback to correctly update the mouseDragSupport setting.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @bazzadazza72 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the duplicate state update logic into a single function to avoid repetition between the ListTile and Switch widgets
• The Switch's onChanged callback receives the new value as a parameter - consider using this directly instead of reading the current state and negating it

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Review instructions: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): The Switch's onChanged callback should use the provided 'value' parameter instead of negating the current value

This could cause incorrect behavior if the switch is toggled rapidly. Use 'value' directly: .update((current) => current.copyWith(mouseDragSupport: value))

[PartyDonut]

Looks good to me, thanks for finding and fixing this 👍🏼