-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix trick play overflow #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request fixes a bug where the trick play window would wander off-screen by clamping the position of the trick play window to the screen bounds. Sequence diagram for trick play window positioningsequenceDiagram
participant User
participant VideoProgressBar
participant Screen
User->>VideoProgressBar: Scrub video
VideoProgressBar->>Screen: Get screen width
Screen-->>VideoProgressBar: Return screen width
VideoProgressBar->>VideoProgressBar: Calculate position
VideoProgressBar->>VideoProgressBar: Clamp position
Note right of VideoProgressBar: Clamp between -10 and<br/>(screenWidth - width)
VideoProgressBar->>User: Display trick play window
State diagram for trick play window position clampingstateDiagram-v2
[*] --> TrickPlayWindow
TrickPlayWindow --> CalculatePosition: User scrubs video
CalculatePosition --> ClampPosition: Position calculated
ClampPosition --> PositionClamped: Clamp between -10 and (screenWidth - width)
PositionClamped --> TrickPlayWindow: Update position
note right of ClampPosition
New clamping logic prevents
window from going off-screen
end note
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PartyDonut - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PartyDonut
changed the title
bugfix: Fix trick play overflow
fix: Fix trick play overflow
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This fixes the trick play window wandering off-screen
Resolves #175