Merge branch 'develop'

.github/workflows/phpcompatibility.yml

@@ -0,0 +1,9 @@
+name: PHPCompatibility
+on: [push]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: 7.0-7.3
+      run: docker run --rm -v $PWD:/code domw/phpcompatibility phpcs --standard=PHPCompatibility --runtime-set testVersion 7.0-7.3 --colors --warning-severity=0 --report=full,summary --extensions=php,phtml ./

.github/workflows/phpcs.yml

@@ -0,0 +1,9 @@
+name: phpcs
+on: [push]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - name: Magento 2 Ruleset
+      run: docker run --rm -v $PWD:/code domw/phpcs phpcs --colors --standard=Magento2 --report=full,summary,gitblame --extensions=php,phtml ./

.github/workflows/phpstan.yml

@@ -0,0 +1,14 @@
+name: PHPStan
+on: [push]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@master
+    - uses: MilesChou/composer-action@master
+      env:
+        COMPOSER_AUTH: ${{secrets.COMPOSER_AUTH}}
+      with:
+        args: install --prefer-dist --no-dev --ignore-platform-reqs
+    - name: PHPStan
+      run: docker run --rm -v $PWD:/code domw/phpstan phpstan analyze ./

.gitignore

@@ -0,0 +1,3 @@
+/vendor
+/.idea
+/.vscode

Console/Command/Category.php

@@ -40,6 +40,16 @@ class Category extends Command
      */
     protected $categoryHelper;
 
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var OutputInterface
+     */
+    protected $output;
+
     /**
      * Category constructor.
      * @param \Psr\Log\LoggerInterface $logger
@@ -81,11 +91,11 @@ protected function execute(
                 (string) __('You are about to generate fake category data. Are you sure? [y/N]'),
                 false
             );
-    
+
             if (!$helper->ask($this->input, $this->output, $question) && $this->input->isInteractive()) {
                 return Cli::RETURN_FAILURE;
             }
-            
+
             $this->output->writeln('[' . $this->dateTime->gmtDate() . '] Start');
 
             $progress = new ProgressBar($this->output, $limit);

Console/Command/Customer.php

@@ -40,6 +40,15 @@ class Customer extends Command
      */
     protected $customerHelper;
 
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var OutputInterface
+     */
+    protected $output;
     /**
      * Customer constructor.
      * @param \Psr\Log\LoggerInterface $logger
@@ -81,7 +90,7 @@ protected function execute(
                 (string) __('You are about to generate fake customer data. Are you sure? [y/N]'),
                 false
             );
-    
+
             if (!$helper->ask($this->input, $this->output, $question) && $this->input->isInteractive()) {
                 return Cli::RETURN_FAILURE;
             }

Console/Command/Order.php

@@ -40,6 +40,16 @@ class Order extends Command
      */
     protected $orderHelper;
 
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var OutputInterface
+     */
+    protected $output;
+
     /**
      * Order constructor.
      * @param \Psr\Log\LoggerInterface $logger
@@ -81,11 +91,11 @@ protected function execute(
                 (string) __('You are about to generate fake order data. Are you sure? [y/N]'),
                 false
             );
-    
+
             if (!$helper->ask($this->input, $this->output, $question) && $this->input->isInteractive()) {
                 return Cli::RETURN_FAILURE;
             }
-            
+
             $this->output->writeln('[' . $this->dateTime->gmtDate() . '] Start');
 
             $progress = new ProgressBar($this->output, $limit);

Console/Command/Product.php

@@ -2,6 +2,8 @@
 
 namespace Xigen\Faker\Console\Command;
 
+use Magento\Catalog\Model\Product\Type;
+use Magento\Framework\App\Area;
 use Magento\Framework\Console\Cli;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\ProgressBar;
@@ -10,8 +12,6 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\ConfirmationQuestion;
-use Magento\Catalog\Model\Product\Type;
-use Magento\Framework\App\Area;
 
 /**
  * Product Console
@@ -44,6 +44,16 @@ class Product extends Command
      */
     protected $productHelper;
 
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var OutputInterface
+     */
+    protected $output;
+
     /**
      * Product constructor.
      * @param \Psr\Log\LoggerInterface $logger
@@ -82,16 +92,19 @@ protected function execute(
 
         if ($generate) {
             $helper = $this->getHelper('question');
-                    
+
             $question = new ConfirmationQuestion(
-                (string) __('You are about to generate fake product data%1. Are you sure? [y/N]', (($image) ? ' with images' : '')),
+                (string) __(
+                    'You are about to generate fake product data%1. Are you sure? [y/N]',
+                    (($image) ? ' with images' : '')
+                ),
                 false
             );
 
             if (!$helper->ask($this->input, $this->output, $question) && $this->input->isInteractive()) {
                 return Cli::RETURN_FAILURE;
             }
-        
+
             $this->output->writeln('[' . $this->dateTime->gmtDate() . '] Start');
 
             $progress = new ProgressBar($this->output, $limit);

Console/Command/Review.php

@@ -40,6 +40,16 @@ class Review extends Command
      */
     protected $reviewHelper;
 
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var OutputInterface
+     */
+    protected $output;
+
     /**
      * Review constructor.
      * @param \Psr\Log\LoggerInterface $logger
@@ -77,12 +87,12 @@ protected function execute(
 
         if ($generate) {
             $helper = $this->getHelper('question');
-            
+
             $question = new ConfirmationQuestion(
                 (string) __('You are about to generate fake review data. Are you sure? [y/N]'),
                 false
             );
-    
+
             if (!$helper->ask($this->input, $this->output, $question) && $this->input->isInteractive()) {
                 return Cli::RETURN_FAILURE;
             }

Helper/Order.php

@@ -66,6 +66,21 @@ class Order extends AbstractHelper
      */
     protected $stockItem;
 
+    /**
+     * @var \Magento\Framework\App\ObjectManager
+     */
+    protected $_objectManager;
+
+    /**
+     * @var Magento\Quote\Api\CartManagementInterface
+     */
+    protected $cartManagementInterface;
+
+    /**
+     * @var Magento\Sales\Model\Service\InvoiceService
+     */
+    protected $invoiceService;
+
     /**
      * Order constructor.
      * @param \Magento\Framework\App\Helper\Context $context

Helper/Product.php

@@ -3,7 +3,6 @@
 namespace Xigen\Faker\Helper;
 
 use Magento\Framework\App\Helper\AbstractHelper;
-use Magento\Catalog\Model\Product\Type;
 
 /**
  * Product helper
@@ -317,7 +316,7 @@ public function getRandomProduct($limit = 1, $inStockOnly = false, $simpleOnly =
         if ($simpleOnly) {
             $collection->addAttributeToFilter('type_id', ['eq' => \Magento\Catalog\Model\Product\Type::TYPE_SIMPLE]);
         }
-        
+
         if ($inStockOnly) {
             $this->stockFilter->addInStockFilterToCollection($collection);
         }

Helper/Review.php

@@ -29,6 +29,16 @@ class Review extends AbstractHelper
      */
     protected $reviewFactory;
 
+    /**
+     * @var \Xigen\Faker\Helper\Customer
+     */
+    protected $customerHelper;
+
+    /**
+     * @var \Xigen\Faker\Helper\Product
+     */
+    protected $productHelper;
+
     /**
      * @var \Magento\Store\Model\StoreManagerInterface
      */

README.md

@@ -1,5 +1,11 @@
 # Faker extension #
 
+![phpcs](https://github.com/DominicWatts/Faker/workflows/phpcs/badge.svg)
+
+![PHPCompatibility](https://github.com/DominicWatts/Faker/workflows/PHPCompatibility/badge.svg)
+
+![PHPStan](https://github.com/DominicWatts/Faker/workflows/PHPStan/badge.svg)
+
 Magento 2 extension to generate fake data.
 
 This extension uses `fzaninotto/faker`

composer.json

@@ -3,7 +3,7 @@
     "description": "Console based fake data generator - just generate what you need",
     "type": "magento2-module",
     "license": "proprietary",
-    "version": "1.1.10",
+    "version": "1.1.11",
     "authors": [
         {
             "name": "Dominic Xigen",
@@ -20,10 +20,11 @@
     "require": {
         "fzaninotto/faker": "*",
         "magento/framework": "*",
-        "php": "~5.6.0||~7.0.0||~7.1.0||~7.2.0||~7.3.0"
-    },
-    "require-dev": {
-        "fzaninotto/faker": "*"
+        "php": "~5.6.0||~7.0.0||~7.1.0||~7.2.0||~7.3.0",
+        "symfony/console": "*",
+        "magento/module-catalog": "*",
+        "magento/module-quote": "*",
+        "magento/module-shipping": "*"
     },
     "autoload": {
         "psr-4": {

etc/module.xml

@@ -1,4 +1,4 @@
 <?xml version="1.0" ?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Xigen_Faker" setup_version="1.1.10"/>
+    <module name="Xigen_Faker" setup_version="1.1.11"/>
 </config>

phpstan.neon

@@ -0,0 +1,11 @@
+parameters:
+    level: 0
+    autoload_directories:
+        - Console
+        - Helper
+    excludes_analyse:
+        - 'vendor'
+    ignoreErrors:
+        - '#invalid typehint#'
+        - '#unknown class#'
+    reportUnmatchedIgnoredErrors: false