Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci: travis - Better test if phpunit completed #32693

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

mdeweerd
Copy link
Contributor

Fix ci: travis - Better test if phpunit completed

Backport travis-ci fix to check phpunit result.

First commit: show error because of 'exit' in SecurityTest.php

2nd commit: backport of fix on SecurityTest.php to clear errored travis build.

# Fix ci: travis - Better test if phpunit completed
@mdeweerd mdeweerd changed the base branch from 19.0 to 20.0 January 17, 2025 22:06
@mdeweerd mdeweerd marked this pull request as ready for review January 17, 2025 22:34
@mdeweerd
Copy link
Contributor Author

@eldy I made several PRs to fix ci, this one to 20.0, another one to 21.0 and one to develop.
I see that your are pushing a lot without integrating these.

We have tried putting a special icon in the PR which did not seem efficient, I am now putting "Fix ci" int he subjet which does not seem efficient, I think I tagged you in one of the other PRs.

Any suggestion how to proceed in the future? Some of the regular contributers may be interested too.

@eldy eldy merged commit e1703e8 into Dolibarr:20.0 Jan 19, 2025
3 checks passed
@mdeweerd mdeweerd deleted the fix/travis/19.0 branch January 19, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants