Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX select on ticket list for fields group and severity (issue #31619) #32122

Open
wants to merge 1 commit into
base: 20.0
Choose a base branch
from

Conversation

thomas-Ngr
Copy link
Contributor

@thomas-Ngr thomas-Ngr commented Nov 27, 2024

FIX select group and severity search fields on ticket list

issue #31619 (indicates 20.0, but I encountered it also on develop)
see also PR #32120 , which is similar but for ticket type, and brings more details.

group and severity must be set when creating/updating a ticket, and have a default value.
However, on search fields, we don't want to set the default value.

This PR sets the default value only if $empty is not set.
These are the changes brought by this PR :

  • when $empty is set (case search lists), the empty value is selected
  • when $empty value is not set, the default value is selected. If there is no default value, an obviously wrong value ('Select group', 'Select severity') is used.

if no default value :
image

@thomas-Ngr thomas-Ngr force-pushed the 20.0_fix_search_select_ticket_list branch from de7edbf to 5f32ace Compare November 27, 2024 14:18
@thomas-Ngr thomas-Ngr force-pushed the 20.0_fix_search_select_ticket_list branch from 5f32ace to b82111c Compare November 27, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant