fix: CronJob Property 'comment' do not exist replace by note_private #31970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we change module template boilerplate and all core module cronjobs creation on activation to change array key name from "comment" to "note_private" to keep consistancy between declaration and field name ?
like in
dolibarr/htdocs/core/modules/modAgenda.class.php
Line 125 in b2bad15
or
dolibarr/htdocs/modulebuilder/template/core/modules/modMyModule.class.php
Line 276 in b2bad15