NEW: use Expedition::$date_shipping property in card and list #31701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonikf
reviewed
Nov 6, 2024
htdocs/expedition/card.php
Outdated
Comment on lines
272
to
273
| $object->date_delivery = $date_delivery; // Date delivery planned | ||
| $object->date_shipping = $date_shipping; // Date delivery planned |
There was a problem hiding this comment.
Hi @altairis-noe
Please change the comment to // Sending date
There was a problem hiding this comment.
Thanks for the review @sonikf. It’s done!
There was a problem hiding this comment.
Can you please change this comment too as it is misleading and makes no sense, planned and expected date has nothing to do with actual date of start
eldy
reviewed
Nov 6, 2024
htdocs/expedition/card.php
Outdated
| @@ -1030,6 +1033,15 @@ | |||
| print '</tr>'; | |||
| } | |||
|
|
|||
| // Date sending | |||
There was a problem hiding this comment.
Fox UX experience, can you move the date of real move after the expected date (we first fill the expected date and then later we fill the real date)
There was a problem hiding this comment.
Hey @eldy,
No problems for me, it’s done!
eldy
added
the
PR to fix - See feedback in comments
|
Hello @eldy, is there still something blocking the merging of that one? |
frederic34
added a commit
to frederic34/dolibarr
that referenced
this pull request
Nov 14, 2024
Debug v21 NEW: use Expedition::$date_shipping property in card and list (Dolibarr#31701) * NEW: use Expedition::$date_shipping property in card and list * FIX: translation * FIX: PHPStan rebutal * FIX: not a great idea to copy and not edit comment * FIX: on create, expected delivery date should precede sending date * Update card.php * Update list.php * Update list.php * Update list.php --------- Co-authored-by: Laurent Destailleur <[email protected]> clean baseline clean baseline clean baseline
eldy
pushed a commit
that referenced
this pull request
Nov 15, 2024
* NEW : Add category feature on Fichinter category update * Update viewcat.php * Update categories.lang * Update categorie.class.php * Update categories.lang * Update viewcat.php * Update viewcat.php * test action * test action * test action * test action * test action * test action * test action * test action * test action * test action * test action * clean baseline Debug v21 NEW: use Expedition::$date_shipping property in card and list (#31701) * NEW: use Expedition::$date_shipping property in card and list * FIX: translation * FIX: PHPStan rebutal * FIX: not a great idea to copy and not edit comment * FIX: on create, expected delivery date should precede sending date * Update card.php * Update list.php * Update list.php * Update list.php --------- Co-authored-by: Laurent Destailleur <[email protected]> clean baseline clean baseline clean baseline * clean baseline * clean baseline * merge * fix * fix * fix * fix * fix * fix * fix translations * fix translations * fix translations * fix translations * fix * fix filters * fix filters * fix filters * fix filters * fix --------- Co-authored-by: Charlène Benke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW use Expedition::$date_shipping property in card and list
Currently, Expedition object does have a
$date_shippingproperty, stored asdate_expeditionin the database.But there is no way in Dolibarr interface to set or display its value.
If your customer wants to know when he will receive the goods, you might want to know when it is gone from your facilities. Here is my proposition.