Update functions.lib.php #28795 #28846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote modification from Pull request Dolibarr#26921 to v18 to resolve issues related to Issue breaking project and third-party dropdowns with reasonably acceptable filters that fail this test.
|
Please help. I really need this bug to be fixed. |
eldy
reviewed
Mar 14, 2024
| @@ -12017,7 +12017,7 @@ function forgeSQLFromUniversalSearchCriteria($filter, &$errorstr = '', $noand = | |||
| $t = preg_replace_callback('/'.$regexstring.'/i', 'dolForgeDummyCriteriaCallback', $filter); | |||
| $t = str_replace(array('and','or','AND','OR',' '), '', $t); // Remove the only strings allowed between each () criteria | |||
| // If the string result contains something else than '()', the syntax was wrong | |||
| if (preg_match('/[^\(\)]/', $t)) { | |||
| if (!preg_match('/[^\(\)]/', $t)) { | |||
There was a problem hiding this comment.
The old code looks good.
What value do you have for "$filter" at begin of function ?
eldy
added
the
Discussion
|
related bug #26921 is closed with more details about the right filter to use then that PR could be closed too i think for me : pr to close @lvessiller-opendsi ? |
ok for me to close this PR |
|
Yes. I agree to open.
…--Charles
On Fri, Jun 14, 2024 at 2:16 AM lvessiller-opendsi ***@***.***> wrote:
related bug #26921 <#26921> is
closed with more details about the right filter to use then that PR could
be closed too i think
for me : pr to close @lvessiller-opendsi
<https://github.com/lvessiller-opendsi> ?
ok for me to close this PR
—
Reply to this email directly, view it on GitHub
<#28846 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMYZ5EBIHJLNNCQAPFJCLZHKKGNAVCNFSM6AAAAABEWKKN6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGM4DSMZVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes. I agree with closing the PR. Please excuse my previous mistaken
response.
…--Charles
On Sat, Jun 15, 2024 at 7:01 PM Charles Beasley ***@***.***>
wrote:
Yes. I agree to open.
--Charles
On Fri, Jun 14, 2024 at 2:16 AM lvessiller-opendsi <
***@***.***> wrote:
> related bug #26921 <#26921> is
> closed with more details about the right filter to use then that PR could
> be closed too i think
>
> for me : pr to close @lvessiller-opendsi
> <https://github.com/lvessiller-opendsi> ?
>
> ok for me to close this PR
>
> —
> Reply to this email directly, view it on GitHub
> <#28846 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADMYZ5EBIHJLNNCQAPFJCLZHKKGNAVCNFSM6AAAAABEWKKN6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGM4DSMZVGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
@eldy |
|
ok i try to click on "close" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote modification from Pull request #26921 to v18 to resolve issues related to Issue breaking project and third-party dropdowns with reasonably acceptable filters that fail this test.
Instructions
This is a template to help you make good pull requests. You may use Github Markdown syntax to format your issue report.
Please:
FIX|Fix #[issue_number Short description]
[Long description]
CLOSE|Close #[issue_number Short description]
[Long description]
NEW|New [Short description]
[Long description]
PERF|Perf #[issue_number Short description]
[Long description]
QUAL|Qual #[issue_number Short description]
[Long description]