Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX PHPStan warnings #28839

Merged
merged 3 commits into from
Mar 15, 2024
Merged

FIX PHPStan warnings #28839

merged 3 commits into from
Mar 15, 2024

Conversation

lamrani002
Copy link
Contributor

No description provided.

eldy
eldy reviewed Mar 14, 2024
View reviewed changes
htdocs/core/modules/member/doc/pdf_standard.class.php Outdated
@@ -263,7 +263,7 @@ public function Add_PDF_card(&$pdf, $textleft, $header, $footer, $outputlangs, $
/**
* Function to build PDF on disk, then output on HTTP stream.
*
* @param Adherent $object Member object. Old usage: Array of record information (array('textleft'=>,'textheader'=>, ...'id'=>,'photo'=>)
* @param mixed $object Member object. Old usage: Array of record information (array('textleft'=>,'textheader'=>, ...'id'=>,'photo'=>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the other types required in addition to Adherent ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to set
Adherent|array

@eldy eldy added Discussion Some questions or discussions are opened and wait answers of author or other people to be processed PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) and removed Discussion Some questions or discussions are opened and wait answers of author or other people to be processed labels Mar 14, 2024
@lamrani002 lamrani002 added the PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... label Mar 15, 2024
@eldy eldy merged commit 7d585f2 into Dolibarr:develop Mar 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldy eldy eldy left review comments

Assignees
No one assigned
Labels
PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamrani002 @eldy