clean code and phpdoc #28773
Merged
clean code and phpdoc #28773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederic34
commented
Mar 11, 2024
| @@ -78,7 +78,7 @@ public function getExample() | |||
| * Checks if the numbers already in the database do not | |||
| * cause conflicts that would prevent this numbering working. | |||
| * | |||
| * @param Object $object Object we need next value for | |||
| * @param Asset $object Object we need next value for | |||
| * @return boolean false if conflict, true if ok | |||
| */ | |||
| public function canBeActivated($object) | |||
There was a problem hiding this comment.
@mdeweerd phan warning here
frederic34
commented
Mar 11, 2024
mdeweerd
reviewed
Mar 11, 2024
|
Maybe the use of templates is the way to go. I did not dive deep into it, but I've seen it in phpstan documentation as well so I guess there is a common support for it and it looks like it could help with the changing signatures. https://github.com/phan/phan/wiki/Generic-Types#declare-template-types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.