Fix some cases of PhanTypeSuspiciousStringExpression #28751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
fix/PhanTypeSuspiciousStringExpression/1
branch
from
56cb9b5
to
13bf3bd
Compare
mdeweerd
force-pushed
the
fix/PhanTypeSuspiciousStringExpression/1
branch
from
723dd68
to
552ac11
Compare
mdeweerd
force-pushed
the
fix/PhanTypeSuspiciousStringExpression/1
branch
from
4f30477
to
290f82f
Compare
eldy
reviewed
Mar 11, 2024
| @@ -297,6 +297,10 @@ private function amountToLetters($montant, $devise1 = '', $devise2 = '') | |||
| $prim = array(); | |||
| $secon = array(); | |||
| $trio = array(); | |||
| '@phan-var string[] $prim | |||
There was a problem hiding this comment.
Did you try to use
/** var string[] $prim */
before the $prim = array();
So this avoid to introduce phan specific code. Dos this trick works ?
There was a problem hiding this comment.
I use phan in other projects - as far as I am used to using PHPDoc does not work here for phan, so I do not try '/** @var ... */ anymore when the case corresponds to something where that would not work.
The documentation explains that this is a limition of AST:
https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#inline-type-checks-via-string-literals
I try to avoid specific code as much as possible myself too.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some cases of PhanTypeSuspiciousStringExpression
PhanTypeSuspiciousStringExpression is generally about using a boolean in "concatenation" to a string.
Fixed mostly by converting to a string value. There were a few cases with a misplaced parentheses in a (cond?X:Y) expression.