Qual: Improve typing hint for (ext)Object, and allow null #28719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
fix/editfieldval_typing
branch
2 times, most recently
from
a953e78
to
3c8f9ec
Compare
# Qual: Improve typing hint for object, and allow null As the key "->element" is expected, the object type should be derived from CommonObject. Also extObject can be nullable
mdeweerd
force-pushed
the
fix/editfieldval_typing
branch
from
3c8f9ec
to
d7a50cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Improve typing hint for object, and allow null
As the key "->element" is expected, the object type should be derived from CommonObject. Also extObject can be nullable