Fix: PhanPossiblyUnsetPropertyOfThis - variable is unset #28714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fix: PhanPossiblyUnsetPropertyOfThis - variable is unset Because the variable is unset to force recomputation, the Phan message is valid and the if condition is always true. Hence, the if condition was commented. Also added an initialisation to an empty array before assigning array fields.
mdeweerd
force-pushed
the
fix/PhanPossiblyUnsetPropertyOfThis
branch
from
6267162
to
a45b29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: PhanPossiblyUnsetPropertyOfThis - variable is unset
Because the variable is unset to force recomputation, the Phan message is valid and the if condition is always true.
Hence, the if condition was commented.
Also added an initialisation to an empty array before assigning array fields.