Update functions.lib.php #28678
Closed
Update functions.lib.php #28678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Mar 7, 2024
| @@ -2987,6 +2987,9 @@ function dol_print_date($time, $format = '', $tzoutput = 'auto', $outputlangs = | |||
| $format = 'daytextshort'; | |||
| } | |||
|
|
|||
| // Make sure the format strings are loaded/updated (#20209) | |||
| $outputlangs->load("main"); | |||
There was a problem hiding this comment.
dol_print_date is a low level memory function called a lot of time.
We should not have instruction into it that make IO like loading file from disk.
The main language file should be loaded by the caller that has initialized the $outputlangs object.
There was a problem hiding this comment.
You are right. I just found a better solution and will make new PR.
eldy
added
the
PR not qualified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20209
When using multiple languages Dolibarr sometimes switches languages depending on settings. By not loading the "main.lang" file, the proper date formats will not be used and this leads to inconsistency.