refactor: use streams

Dokploy · Jan 2, 2025 · 3ec3ff8 · 3ec3ff8
1 parent e3d4280
commit 3ec3ff8
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 130 deletions.
diff --git a/apps/dokploy/server/server.ts b/apps/dokploy/server/server.ts
@@ -34,7 +34,6 @@ void app.prepare().then(async () => {
 		});
 
 		// WEBSOCKET
-		setupMonitoringWebSocketServer(server);
 		setupDeploymentLogsWebSocketServer(server);
 		setupDockerContainerLogsWebSocketServer(server);
 		setupDockerContainerTerminalWebSocketServer(server);

diff --git a/apps/dokploy/server/wss/monitoring.ts b/apps/dokploy/server/wss/monitoring.ts
diff --git a/apps/monitoring/src/containers/index.ts b/apps/monitoring/src/containers/index.ts
@@ -19,6 +19,7 @@ const REFRESH_RATE_CONTAINER = Number(
 	process.env.CONTAINER_REFRESH_RATE || 10000,
 );
 
+const logStreams = new Map<string, fs.WriteStream>();
 export const logContainerMetrics = () => {
 	console.log("Refresh rate:", REFRESH_RATE_CONTAINER);
 
@@ -28,6 +29,11 @@ export const logContainerMetrics = () => {
 	const cleanup = async () => {
 		if (job) {
 			job.cancel();
+
+			for (const stream of logStreams.values()) {
+				stream.end();
+			}
+			// logStreams.forEach((stream) => stream.end());
 		}
 	};
 
@@ -96,9 +102,23 @@ export const logContainerMetrics = () => {
 						}
 					}
 
-					// Escribir la nueva línea
-					await fs.promises.appendFile(containerPath, logLine);
+					if (!logStreams.has(serviceName)) {
+						console.log(logStreams.size);
+						logStreams.set(
+							serviceName,
+							fs.createWriteStream(containerPath, { flags: "a" }),
+						);
+					}
 
+					const stream = logStreams.get(serviceName);
+					if (stream) {
+						if (!stream.write(logLine)) {
+							stream.once("drain", () => stream.write(logLine));
+						}
+					}
+
+					// Escribir la nueva línea
+					// await fs.promises.appendFile(containerPath, logLine);
 				} catch (error) {
 					console.error(
 						`Error writing metrics for container ${container.Name}:`,
@@ -121,7 +141,6 @@ export const logContainerMetrics = () => {
 		Math.floor(REFRESH_RATE_CONTAINER / 1000),
 	);
 
-	console.log(rule);
 	job = schedule.scheduleJob(rule, runMetricsCollection);
 
 	process.on("SIGTERM", cleanup);

diff --git a/apps/monitoring/src/server/server.ts b/apps/monitoring/src/server/server.ts
@@ -49,7 +49,10 @@ const getServerMetrics = async () => {
 };
 
 const REFRESH_RATE_SERVER = Number(process.env.REFRESH_RATE_SERVER || 10000);
-const MAX_FILE_SIZE_MB = Number(process.env.MAX_FILE_SIZE_MB || 10); // 10 MB por defecto
+const MAX_FILE_SIZE_MB = Number(process.env.MAX_FILE_SIZE_MB || 10);
+
+// Crear el WriteStream (mantener abierto para reutilizarlo)
+const logStream = fs.createWriteStream(serverLogFile, { flags: "a" });
 
 export const logServerMetrics = () => {
 	const rule = new schedule.RecurrenceRule();
@@ -87,9 +90,12 @@ export const logServerMetrics = () => {
 			}
 		}
 
-		fs.appendFile(serverLogFile, logLine, (err) => {
-			if (err) console.error("Error to write server metrics:", err);
-		});
+		if (!logStream.write(logLine)) {
+			console.log("Escribiendo....");
+			logStream.once("drain", () => {
+				logStream.write(logLine);
+			});
+		}
 	});
 
 	// Cleanup function