-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAST and XML Compatability #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 19, 2023
dqnykamp
reviewed
Oct 22, 2023
dqnykamp
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
dqnykamp
pushed a commit
to dqnykamp/DoenetML
that referenced
this pull request
Jun 29, 2024
detect if the accessing keyboard caused mathinput blur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
parser.ts
is still around, but it should be reworked to use DAST.type: "error"
node that contains information about parse errors.toXml
function can output proper XML or DoenetML-style markup (e.g., with JSX-style properties). It can also output explicit<_error>
nodes where errors were encountered, or it can silently omit them.showFormatter
attribute toCodeEditor
that will allow for pretty printing of code and for converting between XML and DoenetML