Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
@DoTheEvo
DoTheEvo committed Jul 7, 2024
1 parent ad43824 commit a52026f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions angrysearch.py
100644 → 100755
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,7 @@ def process_q_resuls(self, db_query, db_query_result, words_quoted=None):
self.center.table.selectionModel().selectionChanged.connect(
self.selection_happens)

total = locale.format('%d', len(db_query_result), grouping=True)
total = locale._format('%d', len(db_query_result), grouping=True)

This comment has been minimized.

Sign in to view

Copy link
@danfe

danfe Jul 29, 2024

Could you elaborate on the _format() vs format_string() choice? With Python 3.9.16 I get the following warning:

DeprecationWarning: This method will be removed in a future version of Python.
Use 'locale.format_string()' instead.
self.last_number_of_results = total
self.status_bar.showMessage(total)

Expand Down Expand Up @@ -1238,7 +1238,7 @@ def show_first_500(self):

cur.execute("SELECT COALESCE(MAX(rowid), 0) FROM angry_table")
total_rows_numb = cur.fetchone()[0]
total = locale.format('%d', total_rows_numb, grouping=True)
total = locale._format('%d', total_rows_numb, grouping=True)
self.status_bar.showMessage(total)

def key_press_Enter(self, QModelIndex, shift=False):
Expand Down

7 comments on commit a52026f

@LinuxOnTheDesktop
Copy link

@LinuxOnTheDesktop LinuxOnTheDesktop commented on a52026f Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but is this updated version only for particular systems? I myself am on Mint 21.3, which based on Ubuntu 22.04, and will soon by moving to Mint 22, which is based upon Ubuntu 24.04.

@xiota
Copy link

@xiota xiota commented on a52026f Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoTheEvo I opened orphan request on AUR thinking the package is abandoned because no responses to comments for a very long time. Please enable notifications if they are not enabled.

Although you updated the source and version, the package is still not buildable. I left a comment with changes that are needed. If you need help, you can add me as comaintainer. After updating, if you want to be sole maintainer, I will disown.

After package builds successfully, I will close the orphan request.

@DoTheEvo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiota added you.. I think. Thanks!

@LinuxOnTheDesktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoTheEvo : might I have a reply to my question, please?

@xiota
Copy link

@xiota xiota commented on a52026f Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DoTheEvo I updated the AUR package. I plan to disown in a few days. I'll fix any problems reported before then.

@LinuxOnTheDesktop The change from this commit was requested for Arch Linux, possibly related to Python 3.12. From release notes, it looks like Ubuntu 24.04 uses Python 3.12.

@DoTheEvo
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinuxOnTheDesktop

python versions differences... no plan to solve it, other distros will have to catch up..
I recommend fsearch and disable icons in preferences which fixes the slowness

@LinuxOnTheDesktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I was wondering was whether this the current version of AngrySearch would work on Linux Mint 21.3. Perhaps I should have just tested to see whether it would. I have tested it, just now. It does work. The recommendation of 'fsearch', with its icons disabled, if I find AngrySearch too slow: got it; thanks!

Please sign in to comment.