clean migrations and contracts and enable maxPerToken #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bravepooh
commented
May 3, 2022
bravepooh
commented
- Clean Contracts and migrations folders.
- enable MaxPerToken in allowTokens.sol
koirikivi
reviewed
May 6, 2022
| @@ -163,5 +172,16 @@ contract AllowTokens is IAllowTokens, Ownable { | |||
| minAllowedToken[token] = _minAmount; | |||
| emit FeeAndMinPerTokenChanged(token, _feeConst, _minAmount); | |||
| } | |||
| function setMaxPerToken(address token, uint256 _maxAmount) external onlyOwner { | |||
| require(_maxAmount <= maxTokensAllowed, "AllowTokens: Max Tokens should be equal or smaller than Max Tokens"); | |||
| require(minAllowedToken[token] <= _maxAmount, "AllowTokens: maxAllowedToken[] should be equal or bigger than minAllowedToken[]"); | |||
There was a problem hiding this comment.
You could also validate this in setFeeAndMinPerToken (if maxAllowdToken[token] != 0)
koirikivi
reviewed
May 6, 2022
| @@ -0,0 +1,10 @@ | |||
| const MultiSigWallet = artifacts.require("MultiSigWallet"); | |||
There was a problem hiding this comment.
I don't know how the migrations are used, but is it right to edit the old migration instead of creating a new one?
There was a problem hiding this comment.
cleanup of migrations folder and contracts folder
koirikivi
reviewed
May 6, 2022
|
|
||
| result = await this.allowTokens.isValidTokenTransfer(this.token.address, web3.utils.toWei('2'), 0, true); | ||
| assert.equal(result, true); |
There was a problem hiding this comment.
Maybe add one test here, setMaxPerToken(this.token.address, 0, {from: manage}) and then check that the maximum is unset (ie. 3 is valid again)
koirikivi
reviewed
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.