Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified parser to work without physical id and core id #327

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NekSaikou
Copy link

@Disservin
Copy link
Owner

I think this is indeed a bit more fail safe, though the logical is slightly wrong because it stores it as 1 core with multiple processors, whereas with hyper threading we have two processors per core and with non hyper threading 1 processor per core, this will end up with (possibly) more than 1/2 processors per core. Which is right now no big deal in the code, but the code for the affinity setting is actually a bit flawed.
423bb14#diff-12ba2bd0a2975e9599c30836516443df104515698a92dc945d8146f0ab4dd02fR100
Idk here im making a vector of 1 cpu, and i think with the old core weird stuff would happen with Threads > 1 (engine settings)...

@Disservin Disservin marked this pull request as draft September 27, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants