-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't parse self/ctx parameter annotations of prefix command callbacks #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
t: enhancement
New feature
s: needs review
Issue/PR is awaiting reviews
t: bugfix
labels
Nov 2, 2022
8 tasks
@shiftinv would you please resolve conflicts? |
shiftinv
force-pushed
the
feat/skip-param-parsing
branch
from
November 6, 2023 20:56
d6e7034
to
fdee363
Compare
EQUENOS
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests were successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_signature_parameters
would previously evaluate annotations of all parameters, includingself
/ctx
, which doesn't allow for code like this:Admittedly, that pattern may be rare, but due to this issue a workaround was required in #828.
This PR avoids parsing the annotations of the
self
(if present) andctx
parameter entirely, as they're not relevant for the process.Checklist
task lint
task pyright