Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): implement new entitlement endpoint and parameter #1250

Merged
merged 9 commits into from
Nov 28, 2024
Merged

feat(client): implement new entitlement endpoint and parameter #1250

merged 9 commits into from
Nov 28, 2024

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation t: enhancement New feature labels Nov 24, 2024
shiftinv
shiftinv reviewed Nov 25, 2024
View reviewed changes
changelog/1249.feature.rst Outdated Show resolved Hide resolved
disnake/client.py Outdated Show resolved Hide resolved
disnake/http.py Outdated Show resolved Hide resolved
@Snipy7374 @shiftinv
Update disnake/client.py
b5884d9 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@shiftinv
Copy link
Member

Looks like the new exclude_deleted parameter defaults to true (unlike exclude_ended), we should reflect that here as well: discord/discord-api-docs@e6ac32c#diff-82a22117a97948da6ec935f7b23f3bec7a1d6b4cef7119bb5610d92b95fbeb86R76

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Nov 25, 2024
@Snipy7374 Snipy7374 requested a review from shiftinv November 26, 2024 16:27
@shiftinv shiftinv enabled auto-merge (squash) November 28, 2024 19:58
@shiftinv shiftinv merged commit d24e1de into DisnakeDev:master Nov 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement new entitlement endpoint
2 participants
@Snipy7374 @shiftinv