Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guild): implement new fetch role endpoint #1248

Merged
merged 6 commits into from
Nov 25, 2024
Merged

feat(guild): implement new fetch role endpoint #1248

merged 6 commits into from
Nov 25, 2024

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Nov 24, 2024
@Snipy7374 Snipy7374 changed the title feat(guild): implement new guild guild endpoint feat(guild): implement new guild endpoint Nov 24, 2024
@Snipy7374 Snipy7374 added the t: enhancement New feature label Nov 24, 2024
shiftinv
shiftinv reviewed Nov 25, 2024
View reviewed changes
disnake/guild.py Outdated Show resolved Hide resolved
disnake/guild.py Show resolved Hide resolved
disnake/http.py Outdated Show resolved Hide resolved
Snipy7374 and others added 3 commits November 25, 2024 16:02
@Snipy7374 @shiftinv
Update disnake/guild.py
dda6bf7 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/guild.py
d0ded50 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/http.py
57a8ee3 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 25, 2024
@shiftinv shiftinv changed the title feat(guild): implement new guild endpoint feat(guild): implement new fetch role endpoint Nov 25, 2024
@shiftinv shiftinv enabled auto-merge (squash) November 25, 2024 15:46
shiftinv
shiftinv approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@shiftinv shiftinv merged commit 62f8630 into DisnakeDev:master Nov 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

implement new guild endpoint
2 participants
@Snipy7374 @shiftinv