Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): implement new member flags #1246

Merged
merged 7 commits into from
Nov 26, 2024
Merged

feat(flags): implement new member flags #1246

merged 7 commits into from
Nov 26, 2024

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 requested a review from shiftinv November 22, 2024 23:17
@Snipy7374 Snipy7374 added t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews t: enhancement New feature labels Nov 22, 2024
shiftinv
shiftinv reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tiny adjustments - the new attributes should also all have a .. versionadded::.
Other than that, lgtm!

disnake/flags.py Outdated Show resolved Hide resolved
changelog/1245.feature.rst Outdated Show resolved Hide resolved
@Snipy7374 Snipy7374 requested a review from shiftinv November 26, 2024 16:32
shiftinv
shiftinv approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit 795316e into DisnakeDev:master Nov 26, 2024
28 checks passed
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

implement new member flags
2 participants
@Snipy7374 @shiftinv