Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: use the guild data provided on interactions #1236

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat!: use the guild data provided on interactions #1236

wants to merge 6 commits into from

Conversation

onerandomusername
Copy link
Member

This could in theory use an optimisation of caching the guild, but as we do not have a good way to clear the cache afterwards, this is the best we can implement at this point in time.

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Replacement for #647
Required for #1173

@onerandomusername onerandomusername added the feature request Request for a new feature label Sep 23, 2024
@onerandomusername onerandomusername marked this pull request as draft September 23, 2024 08:33
@onerandomusername
feat!: use the guild data provided on interactions
50cd870 
This could in theory use an optimisation of caching the guild, but  as
we do not have a good way to clear the cache afterwards, this is the
best we can implement at this point in time.
@onerandomusername
add changelog entry
ceac6eb
@onerandomusername onerandomusername force-pushed the arielle/always-provide-guild-for-guild-interactions branch from 40bcbe1 to ceac6eb Compare September 23, 2024 08:38
@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: in progress Issue/PR is being worked on and removed feature request Request for a new feature labels Sep 23, 2024
@shiftinv shiftinv mentioned this pull request Oct 1, 2024
Merged
8 tasks
@shiftinv shiftinv added this to the disnake v2.11 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv Awaiting requested review from shiftinv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s: in progress Issue/PR is being worked on t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Todo
Milestone
disnake v2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv