Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embed): add the ability to pass disnake.File to more Embed methods #1229

Merged
merged 29 commits into from
Nov 16, 2024

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Aug 13, 2024

Summary

Unfortunately seems like the client (at least the web client) have a bug when displaying more than 1 local file uploaded using attachment:// links (this is still unconfirmed). Let me know if this is not true in your local discord client.

For more info check this message

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Aug 13, 2024
@Snipy7374
Copy link
Collaborator Author

Apparently the issue is that the files have all the same filename, we should at least mention this in the docs

disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
changelog/1184.feature.rst Outdated Show resolved Hide resolved
Snipy7374 and others added 5 commits November 13, 2024 16:26
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
disnake/embeds.py Outdated Show resolved Hide resolved
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Copy link
Contributor

@Enegg Enegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some minor docs change suggestions.

Would be nice if we could unify all the parameters under some common Asset object (iirc something hikari does?), but it might be a late call for that
Not very object oriented design smh

disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
@Snipy7374 Snipy7374 requested review from shiftinv and Enegg November 14, 2024 15:54
Copy link
Contributor

@Enegg Enegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
disnake/embeds.py Outdated Show resolved Hide resolved
Snipy7374 and others added 4 commits November 16, 2024 16:45
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@shiftinv shiftinv merged commit aedc1d1 into DisnakeDev:master Nov 16, 2024
28 checks passed
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Local embed icons
3 participants