-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embed): add the ability to pass disnake.File to more Embed methods #1229
Conversation
Apparently the issue is that the files have all the same filename, we should at least mention this in the docs |
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some minor docs change suggestions.
Would be nice if we could unify all the parameters under some common Asset
object (iirc something hikari does?), but it might be a late call for that
Not very object oriented design smh
Co-authored-by: Eneg <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: Eneg <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: Eneg <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Snipy7374 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Summary
Unfortunately seems like the client (at least the web client) have a bug when displaying more than 1 local file uploaded using
attachment://
links (this is still unconfirmed). Let me know if this is not true in your local discord client.For more info check this message
Checklist
pdm lint
pdm pyright