Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip unnecessary release workflow run #1143

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jan 3, 2024

Summary

Followup to #1072.
The Build + Release workflow currently runs on all master/version branch commits, skipping all jobs apart from building the package (i.e. the first one).
Since the Lint + Test workflow also already goes through the same steps and ensures the package builds correctly, we don't need to do all that twice.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

we already try building the package in the lint-test workflow, no need to do the same thing again here
@shiftinv shiftinv added t: meta Changes to the project itself (CI, configs, etc.) skip news labels Jan 3, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jan 3, 2024
@shiftinv shiftinv requested a review from a team as a code owner January 3, 2024 22:01
@shiftinv shiftinv merged commit a5c1a8f into master Jan 3, 2024
27 checks passed
@shiftinv shiftinv deleted the ci/no-commit-build branch January 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: meta Changes to the project itself (CI, configs, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant