Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appcmd): use covariant collection types for choices #1136

Merged
merged 7 commits into from
Nov 25, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Nov 24, 2023

Summary

Updates the Choices type alias to use Sequence/Mapping instead of List/Dict respectively, which were invariant in their value type.
Type checkers would previously complain about commands.Param(choices=<list[str]>), expecting a list[str|int|float] instead.

While not technically supported before, choices=<tuple> used to work prior to 2.9 - see https://canary.discord.com/channels/808030843078836254/1177346079398838272.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 24, 2023
@shiftinv shiftinv merged commit 594c12a into master Nov 25, 2023
27 checks passed
@shiftinv shiftinv deleted the fix/choices-type branch November 25, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: bugfix t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant