fix(appcmd): use covariant collection types for choices
#1136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
Choices
type alias to useSequence
/Mapping
instead ofList
/Dict
respectively, which were invariant in their value type.Type checkers would previously complain about
commands.Param(choices=<list[str]>)
, expecting alist[str|int|float]
instead.While not technically supported before,
choices=<tuple>
used to work prior to 2.9 - see https://canary.discord.com/channels/808030843078836254/1177346079398838272.Checklist
pdm lint
pdm pyright