fix(commands): resolve unstringified annotation before caching #1120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
utils.evaluate_annotation
uses a (per-signature) cache to speed up resolving forwardrefs.This would previously cache the
eval
'd result before continuing to resolve it, meaning subsequent calls with the same stringified annotation return the (incomplete) cached result.The same thing happens with other unique
evaluate_annotation
behaviors, like turningUnionType
s intoUnion
s.The correct behavior here is to cache after we've done all the remaining steps.
Checklist
pdm lint
pdm pyright