Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): add the new ex query param to Attachment with some util property #1118

Closed
wants to merge 2 commits into from

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Oct 11, 2023

Summary

Mostly waiting for docs

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

disnake/message.py Outdated Show resolved Hide resolved
@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Oct 12, 2023
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Feb 13, 2024
@shiftinv
Copy link
Member

Thanks for the PR! It seems unusual to retain Attachment objects for several days, handling the possible expiry feels like something that should be done in the application rather than the library.
The expiry on new attachments is currently ~14 days, and attachments returned by the API (e.g. from fetching a message) get refreshed automatically and should always be valid in that moment; therefore this shouldn't concern most people.

@shiftinv shiftinv closed this Feb 13, 2024
@Snipy7374 Snipy7374 deleted the feat/attachments branch February 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants