-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select menu default values #1115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way we avoid having to create a set in _transform_default_values
shiftinv
added
t: enhancement
New feature
t: api support
Support of Discord API features
s: needs review
Issue/PR is awaiting reviews
labels
Oct 7, 2023
shiftinv
force-pushed
the
feature/select-default-values
branch
from
September 7, 2024 17:08
de11ff8
to
de0ca0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
s: needs review
Issue/PR is awaiting reviews
t: api support
Support of Discord API features
t: enhancement
New feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
discord/discord-api-docs@515931a
This implements the new
default_values
field for auto-populated (i.e. non-string) select menus. The PR is pretty much finished, but it could use some more testing.Note that this doesn't currently implement
message.resolved
, which contains resolved objects forcomponents[*].default_values
. We have nowhere to put this data right now, since component objects store plainSelectDefaultValue
s, but implementing it in the future would be pretty simple. The data isn't all that useful in most cases, anyway.Checklist
pdm lint
pdm pyright