Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select menu default values #1115

Merged
merged 28 commits into from
Nov 14, 2024
Merged

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Oct 7, 2023

Summary

discord/discord-api-docs@515931a

This implements the new default_values field for auto-populated (i.e. non-string) select menus. The PR is pretty much finished, but it could use some more testing.

Note that this doesn't currently implement message.resolved, which contains resolved objects for components[*].default_values. We have nowhere to put this data right now, since component objects store plain SelectDefaultValues, but implementing it in the future would be pretty simple. The data isn't all that useful in most cases, anyway.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Oct 7, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Oct 7, 2023
@shiftinv shiftinv force-pushed the feature/select-default-values branch from de11ff8 to de0ca0a Compare September 7, 2024 17:08
@shiftinv shiftinv merged commit ef7d82f into master Nov 14, 2024
28 checks passed
@shiftinv shiftinv deleted the feature/select-default-values branch November 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant