Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deduplicate owner_ids logic #1109

Merged
merged 3 commits into from
Sep 23, 2023
Merged

refactor: deduplicate owner_ids logic #1109

merged 3 commits into from
Sep 23, 2023

Conversation

shiftinv
Copy link
Member

Summary

Removes some duplication related to fetching owner_id(s) in Bot._fill_owners and Bot.is_owner.
Waiting for connect isn't necessary anymore if we do the login first, which puts http into a usable state.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes skip news labels Sep 22, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Sep 22, 2023
@shiftinv shiftinv requested a review from EQUENOS September 22, 2023 17:58
Copy link
Member

@EQUENOS EQUENOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shiftinv shiftinv mentioned this pull request Sep 22, 2023
8 tasks
@shiftinv shiftinv merged commit 862db86 into master Sep 23, 2023
26 of 27 checks passed
@shiftinv shiftinv deleted the refactor/owner-ids branch September 23, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews skip news t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants