fix: don't pop key in `MessageReference.with_state` #1093

shiftinv · 2023-08-23T21:40:35Z

Summary

This doesn't affect 99.9% of cases, but there's no reason to mutate the data here regardless.
https://canary.discord.com/channels/808030843078836254/942319505915412500/1144016456447688835

If code changes were made, then they have been tested
- I have updated the documentation to reflect the changes
- I have formatted the code properly by running pdm lint
- I have type-checked the code by running pdm pyright
This PR fixes an issue
This PR adds something new (e.g. new method or parameters)
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)

shiftinv added t: bugfix skip news needs backport: 2.9 labels Aug 23, 2023

shiftinv added this to the disnake v2.10 milestone Aug 23, 2023

fix: don't pop key in MessageReference.with_state

0a7f92a

shiftinv force-pushed the fix/message-reference-keys branch from e089c61 to 0a7f92a Compare August 23, 2023 21:51

shiftinv merged commit 77d8ee6 into master Aug 23, 2023

shiftinv deleted the fix/message-reference-keys branch August 23, 2023 22:02

shiftinv added a commit that referenced this pull request Oct 30, 2023

fix: don't pop key in MessageReference.with_state (#1093)

a8da5e4

shiftinv removed the needs backport: 2.9 label Oct 30, 2023