feat(commands.cog): pass errors raised by cog_unload to the bot's on_…

…error (#1067)
DisnakeDev · Aug 20, 2023 · 18cc029 · 18cc029
1 parent a491421
commit 18cc029
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/changelog/1046.feature.rst b/changelog/1046.feature.rst
@@ -0,0 +1 @@
+|commands| Log errors raised by :meth:`.ext.commands.Cog.cog_unload`.
diff --git a/disnake/ext/commands/cog.py b/disnake/ext/commands/cog.py
@@ -4,6 +4,7 @@
 
 import asyncio
 import inspect
+import logging
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -48,6 +49,7 @@
 FuncT = TypeVar("FuncT", bound=Callable[..., Any])
 
 MISSING: Any = disnake.utils.MISSING
+_log = logging.getLogger(__name__)
 
 
 def _cog_special_method(func: FuncT) -> FuncT:
@@ -895,6 +897,7 @@ def _eject(self, bot: AnyBot) -> None:
                 pass
             try:
                 self.cog_unload()
-            except Exception:
-                # TODO: Consider calling the bot's on_error handler here
-                pass
+            except Exception as e:
+                _log.error(
+                    "An error occurred while unloading the %s cog.", self.qualified_name, exc_info=e
+                )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		\|commands\| Log errors raised by :meth:`.ext.commands.Cog.cog_unload`.