Update docker.md #59
Merged
Update docker.md #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"From a practical point of view, Docker makes it very easy for you to try and use a wide variety of applications and environments. For example you can start a local (fully working) instance of the [ELK Stack](https://www.elastic.co/elk-stack) (Elastic search + Logstash + Kibana) in Docker, simply by running the `sudo Docker pull sebp/elk` command (without installing anything on your host machine). " -- do you assume the reader is already familiar with these concepts? If yes than ok, but if not you might lose them here with the technical jargon. You might want to add a paragraph or two to explain a bit more about the stack. or maybe move this section altogether to later in the book. "### It all started with physical containers" - this section could move to before Docker and Kubernetes minor typos
|
thx, added issue #62 to track the comment (which I agree with) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"From a practical point of view, Docker makes it very easy for you to try and use a wide variety of applications and environments. For example you can start a local (fully working) instance of the ELK Stack (Elastic search + Logstash + Kibana) in Docker, simply by running the
sudo Docker pull sebp/elkcommand (without installing anything on your host machine)." -- do you assume the reader is already familiar with these concepts? If yes than ok, but if not you might lose them here with the technical jargon. You might want to add a paragraph or two to explain a bit more about the stack. or maybe move this section altogether to later in the book.
"### It all started with physical containers" - this section could move to before Docker and Kubernetes
minor typos