1.13.1 #50
1.13.1 #50
Conversation
|
@Chocohead yeah it is lol 👍 nice spot |
| @@ -30,7 +30,7 @@ public ArmorMaterialImpl(String name, int maxDamageFactor, int[] damageReduction | |||
|
|
|||
| @Override | |||
| public int getDurability(EntityEquipmentSlot slot) { | |||
| return ArmorMaterial.MAX_DAMAGE_ARRAY[slot.getIndex()] * maxDamageFactor; | |||
| return getDurability(slot) * maxDamageFactor; | |||
There was a problem hiding this comment.
Won't this just call itself recursively?
| import net.minecraft.util.registry.RegistryNamespaced; | ||
| import net.minecraft.world.WorldServer; | ||
|
|
||
| import java.util.function.Predicate; | ||
|
|
||
| public abstract class Message { | ||
| public static final RegistryNamespaced<ResourceLocation, Class<? extends Message>> REGISTRY = new RegistryNamespaced<>(); |
There was a problem hiding this comment.
Should the "message" string not be namespaced?
There was a problem hiding this comment.
Should be better, I wasn't sure if it was best to add a new class or use mixin's to add the method straight to IRegistry
|
How does setting up MCP for 1.13.1 work |
|
I've got a half finished version of FG2 that is designed to take the newer FG3 config style here, theoretically all that needs finishing is |
|
@Chocohead is taking this PR over, see #58 |
Please review current state
Find MCP yourself I dont agree with re-hosting it, this should be changed
Compiles, loads into a world. No mods have been tested
Still to do: