refactor: opt by million #3439
Draft
refactor: opt by million #3439
+1,775
−723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guanbinrui
force-pushed
the
refactor/million
branch
from
abd2446 to
837c105
Compare
guanbinrui
force-pushed
the
refactor/million
branch
from
837c105 to
63b4ed4
Compare
guanbinrui
force-pushed
the
refactor/million
branch
2 times, most recently
from
bfffdf2 to
f9f7f5b
Compare
guanbinrui
force-pushed
the
refactor/million
branch
from
4f5798e to
2f40dc3
Compare
guanbinrui
requested review from
LeifXu,
nuanyang233 and
dudu0506
and removed request for
LeifXu and
nuanyang233
nuanyang233
reviewed
Dec 12, 2024
| return await decryptMetrics(cipher, signal); | ||
| return await decryptMetrics(cipher, signal); | ||
| } catch { | ||
| return []; |
There was a problem hiding this comment.
Don't do that. We only use EMPTY_LIST/EMPTY_OBJECT inside react components and hooks which follow the immutable principle.
function fn() {
return condition ? ['mutable', 'array'] : EMPTY_LIST
}
const arr = fn()
// You can't do it for EMPTY_LIST
arr.push('new item')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Related Issue
Closes FW-0000
Checklist