Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular and refactor #551

Merged
merged 20 commits into from
Sep 3, 2021
Merged

Update angular and refactor #551

merged 20 commits into from
Sep 3, 2021

Conversation

waltersajtos
Copy link
Member

@waltersajtos waltersajtos commented Jul 7, 2021

Description

Felt sorry for the next semester so I decided to refactor some things that were either huge files or just broken in general. Also finally updated to angular 11.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

The entire overview and detail page need to be fully tested.

Link to issue

Closes: #385 #437 #450

@waltersajtos waltersajtos self-assigned this Jul 7, 2021
@waltersajtos waltersajtos changed the title remove entryComponents (angular update) Update angular and refactor Jul 7, 2021
@RubenFricke RubenFricke requested a review from DaveBouman July 13, 2021 14:14
@Brend-Smits
Copy link
Member

Brend-Smits commented Sep 2, 2021

I will have a look at this in the coming week. @rubenb994 or @niraymak, could you also have a look please? Would be great to get this PR merged.

@MeesvanStraten
Copy link
Contributor

@Brend-Smits @DaveBouman and I will also review it. Want to have this PR merged before other team members will work on DeX.

@MeesvanStraten MeesvanStraten self-requested a review September 3, 2021 10:13
@Brend-Smits
Copy link
Member

@Brend-Smits @DaveBouman and I will also review it. Want to have this PR merged before other team members will work on DeX.

That's great. I will sit on standby in that case. Let me know if you need a third pair of eyes.

MeesvanStraten
MeesvanStraten previously approved these changes Sep 3, 2021
DaveBouman
DaveBouman previously approved these changes Sep 3, 2021
@MeesvanStraten MeesvanStraten dismissed stale reviews from DaveBouman and themself via e2ad52c September 3, 2021 10:57
@DaveBouman DaveBouman self-requested a review September 3, 2021 11:02
@DaveBouman DaveBouman merged commit 76503b7 into develop Sep 3, 2021
@DaveBouman DaveBouman deleted the refactor-juli branch September 3, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Friday - Update to Angular 11
4 participants