Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close project modal on going back #437

Open
RubenFricke opened this issue Mar 9, 2021 · 3 comments
Open

Close project modal on going back #437

RubenFricke opened this issue Mar 9, 2021 · 3 comments
Labels
bug Something isn't working Refactor Friday This label is used to mark an issue for a planned refactor

Comments

@RubenFricke
Copy link
Member

Describe the bug
When you open a project modal, this should get closed when you go back using the browser navigation while the project overview page remains the page that is currently loaded.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the project overview page
  2. Click on a project
  3. The project modal will pop up
  4. Go back using the browser navigation
  5. You will get redirected to the homepage

Expected behavior
When you go back, only the project modal should get closed. The project overview page should still be opened page.

@RubenFricke RubenFricke added bug Something isn't working Refactor Friday This label is used to mark an issue for a planned refactor labels Mar 9, 2021
@waltersajtos
Copy link
Member

I guess this can be closed since #423 was fixed?

@RubenFricke
Copy link
Member Author

I guess this can be closed since #423 was fixed?

This is something else. After #423 was merged we noticed that when you go back a page when the popup is loaded on the overview page, you would get redirected to the homepage (if you redirected via the homepage of course). But it would make more sense if the popup would get closed when you go back, but remain on the overview page.

#423 was only responsible for closing the modal if you go to another page, but you would still get redirected to the homepage.

I hope this makes sense, otherwise let me know. Good catch though 😉

@waltersajtos waltersajtos self-assigned this Apr 4, 2021
@waltersajtos
Copy link
Member

I guess this can be closed since #423 was fixed?

This is something else. After #423 was merged we noticed that when you go back a page when the popup is loaded on the overview page, you would get redirected to the homepage (if you redirected via the homepage of course). But it would make more sense if the popup would get closed when you go back, but remain on the overview page.

#423 was only responsible for closing the modal if you go to another page, but you would still get redirected to the homepage.

I hope this makes sense, otherwise let me know. Good catch though 😉

This made sense indeed, the issue title was what confused me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Refactor Friday This label is used to mark an issue for a planned refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants