Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added twitter logo to all pages in footer #1045

Merged

Conversation

likitha-kapu
Copy link

🚀 Pull Request

Description

The footer section includes social media links but is missing a Twitter logo, making it incomplete for users who may want to connect via Twitter.

This change adds the Twitter logo to the footer section, completing the social media links to enhance user connectivity. The update ensures that users can engage with the website via Twitter, aligning with existing social media options. This required verifying and including the correct Font Awesome library, which supports the fa-twitter icon, with no new dependencies needed apart from Font Awesome itself.

Type of Change

  • [X ] New feature (non-breaking change which adds functionality)

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [x ] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes

Screenshot of final output/video

image

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ice-cream-parlour-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 5:02am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @likitha-kapu for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Owner

@DharshiBalasubramaniyam DharshiBalasubramaniyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly resolve conflicts.

@DharshiBalasubramaniyam DharshiBalasubramaniyam merged commit a0830ce into DharshiBalasubramaniyam:master Nov 2, 2024
2 checks passed
@DharshiBalasubramaniyam DharshiBalasubramaniyam added level2 and removed question Further information is requested labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: TWITTER LOGO NEED TO BE ADDED IN FOOTER SECTION
2 participants