-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded "mongodb" npm package to 3.4.1 #20
Open
enosrecanati
wants to merge
12
commits into
DevSlop:master
Choose a base branch
from
enosrecanati:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of deprecation warnings now on MongoDB client methods calls during the debug, a little bit of refactoring needed to prevent them.
…ationWarning while connection to the database Complete DeprecationWarning previously displayed during debug: "(node:74519) DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor."
Completed DeprecationWarning message previously displayed while debugging: "(node:74838) DeprecationWarning: collection.findAndModify is deprecated. Use findOneAndUpdate, findOneAndReplace or findOneAndDelete instead."
Completed DeprecationWarning message previously displayed while debugging: "(node:78105) DeprecationWarning: collection.insert is deprecated. Use insertOne, insertMany or bulkWrite instead."
Completed DeprecationWarning message previously displayed while debugging: "(node:78305) DeprecationWarning: collection.remove is deprecated. Use deleteOne, deleteMany, or bulkWrite instead."
…e MongoDB driver after the upgrade the options [servers] is not supported the options [caseTranslate] is not supported the options [dbName] is not supported They are related to ConnectionPooling and the suggestions are to connect one and let the Driver manage the pool, https://mongodb.github.io/node-mongodb-native/1.4/driver-articles/mongoclient.html#mongoclient-connection-pooling
Allows to start the application to be launched from another folder (eg. using VSCode Debug/Run tab) saving the uploaded pictures in the right folder
as per README the default launch conguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded "mongodb" npm package to 3.4.1
Now it's possible to run the application using MongoDB server from 2.6 to 4.2; verified with:
It's also possible to user Node.js runtime from 4.x.x to 12.x.x; verified with:
MongoDB driver compatibility matrix: https://docs.mongodb.com/ecosystem/drivers/driver-compatibility-reference/#node-js-driver-compatibility
In addition, now "counters" collection documents are now auto initialized if doesn't exist. Useful if launched on localhost with an empty database, instead of using the docker image.