HtmlEditor: Fix for context menu not closing when escape button pressed #28871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…25_1-html-editor-focus-issue-in-context-menu
ksercs
reviewed
Jan 30, 2025
| @@ -71,6 +71,15 @@ if (Quill) { | |||
| eventsEngine.off(this.editorInstance._getContent(), CONTEXT_MENU_EVENT); | |||
| } | |||
|
|
|||
| _escKeyHandler() { | |||
| this._contextMenu.hide(); | |||
There was a problem hiding this comment.
[excess actions]
No need to call it here. Escape hides contextMenu by default, we only need to additonally focus the editor.
| } | ||
|
|
||
| _addEscapeHandler(e) { | ||
| e.component.registerKeyHandler('escape', this._escKeyHandler.bind(this)); |
There was a problem hiding this comment.
[refactoring]
I think it's overhead to create a separate method for _escKeyHandler. Let's just pass an arrow function here
| this.editorInstance.focus(); | ||
| } | ||
|
|
||
| _addEscapeHandler(e) { |
There was a problem hiding this comment.
Let's name it a bit wider while this method if passed to initialized
Suggested change
| _addEscapeHandler(e) { | |
| _onContextMenuInitialized(e) { |
| $tableElement.trigger('dxcontextmenu'); | ||
| this.clock.tick(10); | ||
| const container = this.quillInstance.container; | ||
| $(container).trigger($.Event('keydown', { key: 'Escape', keyCode: 27, which: 27 })); |
There was a problem hiding this comment.
This is supposed to be triggered on a contextMenu element
| this.createWidget(); | ||
|
|
||
| const $tableElement = this.$element.find('td').eq(0); | ||
| $tableElement.trigger('dxcontextmenu'); |
There was a problem hiding this comment.
[copypaste]
Please use helper utils. U used this.createWidget, why don't u use this.getContextMenu?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.