-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiView: Add unit tests for keyboard navigation with hidden items #28137
Merged
nikkithelegendarypokemonster
merged 13 commits into
DevExpress:24_2
from
nikkithelegendarypokemonster:24_2-multiview-integrate-visibility-in-kbn
Oct 7, 2024
Merged
MultiView: Add unit tests for keyboard navigation with hidden items #28137
nikkithelegendarypokemonster
merged 13 commits into
DevExpress:24_2
from
nikkithelegendarypokemonster:24_2-multiview-integrate-visibility-in-kbn
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…24_2-multiview-integrate-visibility-in-swipe-action
…ttps://github.com/nikkithelegendarypokemonster/DevExtreme into 24_2-multiview-integrate-visibility-in-kbn
ksercs
changed the title
MultiView: Add unit tests for keyboard navigation with visible items
MultiView: Add unit tests for keyboard navigation with hidden items
Oct 3, 2024
ksercs
reviewed
Oct 3, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
…tion' of https://github.com/nikkithelegendarypokemonster/DevExtreme into 24_2-multiview-integrate-visibility-in-kbn" This reverts commit 5f27f19, reversing changes made to f871d6a.
…24_2-multiview-integrate-visibility-in-kbn
ksercs
previously approved these changes
Oct 4, 2024
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/multiView.tests.js
Outdated
Show resolved
Hide resolved
…24_2-multiview-integrate-visibility-in-kbn
ksercs
approved these changes
Oct 7, 2024
marker-dao
approved these changes
Oct 7, 2024
nikkithelegendarypokemonster
merged commit Oct 7, 2024
c161a8b
into
DevExpress:24_2
278 checks passed
ivanblinov2k17
added a commit
to ivanblinov2k17/DevExtreme
that referenced
this pull request
Oct 22, 2024
Core: fix imports Core: fix imports for templates Core: fix/ignore eslint errors Core: fix most of typescript issues Core: fix most of extraneous TS errors (mostly redundant ts-expect-error) Core: fix/ignore remaining extraneous errors Core: fix broken renovation import Core: fixed callOnce import Core: fix TS lint errors Core: fix component_registrator_callbacks reexport Core: fixed missed Data reexport + silence Mock TS error Core: fixed unwanted refactoring for renderer (using array methods on array-like objects) Core: add missing template reexport Core: fix artifacts of auto-replace Core: Fix data and utils modules Core: fix Error constructor Core: fix viewport IIFE after lint changes and add it to lint ignore Core: TEST - add lint ignore for all core, bring back changes, that seem significant to see how they impact test Core: TEST - bring back non-significant cahanges to see if they impact tests Core: fix tests for editors and core Core: fix qunit part 2 Core: common default export + bring back executeAsyncMock 10 line Core: fix textbox hanging test (blur) Core: fix test Html editor - PopupModule mock window Core: fix transitionExecutor + datebox knockout tests Core: fix animation/fx tests Core: fix animation/fx test part 2 Core: fix imageCreator exporter test Core: fix defaultOption tests Map - deprecate Bing provider (DevExpress#28127) GridBaseOptions.columnFixing.texts.stickPosition -> GridBaseOptions.columnFixing.texts.stickyPosition (DevExpress#28133) Co-authored-by: Roman Semenov MultiView: improve swipe UX when some items are hidden (DevExpress#28128) Fix CodeQL report errors (DevExpress#27874) Selection: fix selection cache updating after selection change is canceled (DevExpress#28141) Replace get-changed-files action with the shared one (DevExpress#28140) MultiView: Add unit tests for keyboard navigation with hidden items (DevExpress#28137) chore(deps): update dependency vite to v5 [security] (DevExpress#28147) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(deps): update pnpm to v9.11.0 (DevExpress#28158) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> HtmlEditor: Get rid of showdown Co-authored-by: marker dao ® <[email protected]> Co-authored-by: Roman Semenov <[email protected]> 🎹 Pager: Create d.ts (DevExpress#28055) Co-authored-by: alexlavrov <[email protected]> Co-authored-by: ilyakhd <[email protected]> Co-authored-by: Roman Semenov <[email protected]> Pager - rename filename (DevExpress#28163) HtmlEditor: Get rid of turndown dxDiagram - fix T1251559, T1254101 (DevExpress#28168) HtmlEditor: Remove markdown support Map - add Azure provider in declarations (DevExpress#28126) Chat: add empty view stories (DevExpress#28173) Chat: Skip message rendering on send message (DevExpress#28170) Co-authored-by: marker dao ® <[email protected]> Refix "Storybook - fix project config (DevExpress#28085)" (DevExpress#28144) Scheduler a11y: appointments does not have info about reccurence (DevExpress#28165) Map - support Azure provider (DevExpress#28122) Core: fix azure provider TS error Core: fix m_svg to contain default export Core: fix popup test Core: fix regular popup tests Core: Fix toolbar + loadIndicator Core: Fix viz pieChart + rangeSelector Core: fix desktopTooltip test Core: fix ui-firefox Core: Replace all imports Action, devices -> m_action, m_devices Core: domAdapter -> m_dom_adapter tests Core: fix m_action export Core: replace import support -> m_support Core: dom -> m_dom;: common, type -> m_ only for helpers Core: fix ui-firefox single test failures Core: fix rowsView test Core: fix pivotGrid async mocks Core: fix pivotGrid dataSource.bundled Core: dataSource bundled add missing inflector import Core: internal support -> m_support Core: use ts device in events to try to fix mobile tests Core: remove unexpected ts-error Core: replace dom->m_dom click event Core: fix scrollable test (in mobileViewport) Fix eslint rules and apply them to utils, templates, options and ignore errors Core: modify eslint config, save core files Core: fix metadata Core: fix TS lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.