Skip to content

Commit

Permalink
HtmlEditor: Get rid of turndown
Browse files Browse the repository at this point in the history
  • Loading branch information
marker dao ® committed Oct 9, 2024
1 parent 65b5555 commit 706896e
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 46 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { getWindow } from '@js/core/utils/window';
import Errors from '@js/ui/widget/ui.errors';
import TurnDown from 'turndown';

import converterController from '../m_converterController';

Expand All @@ -12,7 +11,7 @@ class MarkdownConverter {
constructor() {
const window = getWindow();
// @ts-expect-error
const turndown = window && window.TurndownService || TurnDown;
const turndown = window && window.TurndownService;
// @ts-expect-error
const showdown = window && window.showdown;

Expand Down
3 changes: 1 addition & 2 deletions packages/devextreme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
"inferno": "^7.4.9",
"inferno-hydrate": "^7.4.9",
"jszip": "^3.10.1",
"rrule": "^2.7.1",
"turndown": "~7.1.0"
"rrule": "^2.7.1"
},
"devDependencies": {
"@babel/core": "7.23.9",
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@
'fflate': '@Url.Content("~/packages/devextreme/node_modules/fflate/esm/browser.js")',
'jspdf': '@Url.Content("~/packages/devextreme/node_modules/jspdf/dist/jspdf.umd.js")',
'jspdf-autotable': '@Url.Content("~/packages/devextreme/node_modules/jspdf-autotable/dist/jspdf.plugin.autotable.js")',
'turndown': '@Url.Content("~/packages/devextreme/node_modules/turndown/lib/turndown.browser.umd.js")',
'rrule': '@Url.Content("~/packages/devextreme/node_modules/rrule/dist/es5/rrule.js")',
// Inferno
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
require('../../helpers/ignoreQuillTimers.js');
require('./htmlEditorParts/importTurnDown.tests.js');

This file was deleted.

1 change: 0 additions & 1 deletion packages/devextreme/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = {
'globalize/date': 'window.Globalize',
'globalize/message': 'window.Globalize',
'devextreme-quill': 'window.DevExpress.Quill',
'turndown': 'window.TurndownService',
'exceljs': 'window.ExcelJS',
'jspdf': 'window.jspdf.jsPDF',
'devexpress-diagram': 'window.DevExpress.diagram',
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 706896e

Please sign in to comment.