TabPanel: Fix updating tabs indicator position (#25957)

DevExpress · Nov 6, 2023 · 1d44c1a · 1d44c1a
1 parent 7f45386
commit 1d44c1a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/devextreme/js/ui/tab_panel.js b/packages/devextreme/js/ui/tab_panel.js
@@ -423,7 +423,7 @@ const TabPanel = MultiView.inherit({
     _updateTabsIndicatorPosition() {
         const value = this._getTabsIndicatorPosition();
 
-        this.option('_tabsIndicatorPosition', value);
+        this._setTabsOption('_indicatorPosition', value);
     },
 
     _optionChanged: function(args) {

diff --git a/packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js b/packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js
@@ -811,6 +811,21 @@ QUnit.module('Tabs Indicator position', () => {
 
         assert.notOk($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['top']));
         assert.ok($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['left']));
+
+        tabPanel.option({ tabsPosition: 'bottom' });
+
+        assert.notOk($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['left']));
+        assert.ok($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['bottom']));
+
+        tabPanel.option({ tabsPosition: 'right' });
+
+        assert.notOk($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['bottom']));
+        assert.ok($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['right']));
+
+        tabPanel.option({ tabsPosition: 'top' });
+
+        assert.notOk($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['right']));
+        assert.ok($tabs.hasClass(TABS_INDICATOR_POSITION_CLASS_BY_TABS_POSITION['top']));
     });
 
     QUnit.test('The tabs element must have the correct indicator position class when _tabsIndicatorPosition was changed', function(assert) {