Properly handle muted and controls video attributes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitriques
requested changes
Oct 30, 2024
| export let controls = true; | ||
| export let el: HTMLVideoElement | undefined = undefined; | ||
|
|
||
| const updateAttribute = (attr: string, value: boolean) => { |
There was a problem hiding this comment.
Can we add a comment in the code about the issue with svelte please ? Thanks !
f-elix
force-pushed
the
felix/html-video-fix
branch
from
03559fc to
c690f55
Compare
|
Cc @vsylvestre same as your bug right ? |
|
By the way this is supposed to be fixed in Svelte 5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason Svelte doesn't correctly handle those attributes (see sveltejs/svelte#6536). I don't know how we didn't catch this earlier, but this PR works around the issue.
Closes #9